Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip Indexing Unnecessary Compartment Values #1045

Merged
merged 1 commit into from
Jul 7, 2023

Conversation

alexanderkiel
Copy link
Member

@alexanderkiel alexanderkiel commented Jul 3, 2023

This changes saves about 23% disk space in the index database.

@alexanderkiel alexanderkiel force-pushed the compartment-index branch 2 times, most recently from df7e38d to 584920c Compare July 4, 2023 11:35
@codecov
Copy link

codecov bot commented Jul 4, 2023

Codecov Report

Merging #1045 (584920c) into develop (3599293) will decrease coverage by 0.08%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1045      +/-   ##
===========================================
- Coverage    94.48%   94.40%   -0.08%     
===========================================
  Files          243      243              
  Lines        15639    15640       +1     
  Branches       368      367       -1     
===========================================
- Hits         14776    14765      -11     
- Misses         495      508      +13     
+ Partials       368      367       -1     
Impacted Files Coverage Δ
modules/db/src/blaze/db/impl/search_param.clj 100.00% <100.00%> (ø)
...odules/db/src/blaze/db/impl/search_param/token.clj 95.31% <100.00%> (ø)
...dules/rest-api/src/blaze/rest_api/capabilities.clj 97.39% <100.00%> (ø)

... and 2 files with indirect coverage changes

This changes saves about 23% disk space in the index database.
@alexanderkiel alexanderkiel changed the title [WIP] Skip Indexing Unnecessary Compartment Values Skip Indexing Unnecessary Compartment Values Jul 7, 2023
@alexanderkiel alexanderkiel self-assigned this Jul 7, 2023
@alexanderkiel alexanderkiel added module:db performance Performance improvement labels Jul 7, 2023
@alexanderkiel alexanderkiel added this to the v0.22.1 milestone Jul 7, 2023
@alexanderkiel alexanderkiel merged commit b775b0f into develop Jul 7, 2023
@alexanderkiel alexanderkiel deleted the compartment-index branch July 7, 2023 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module:db performance Performance improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant