Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consume the Whole Inputstream of Request Payloads #594

Merged
merged 1 commit into from
Jan 30, 2022

Conversation

alexanderkiel
Copy link
Member

@alexanderkiel alexanderkiel commented Jan 29, 2022

Versions of Blaze from 0.13.2 to 0.15.3, starting with the migration to Jetty, had the problem that the JSON parser did not read the entire inputstream so that terminal chunks could remain, which caused Jetty to close the stream.

@alexanderkiel alexanderkiel self-assigned this Jan 29, 2022
@alexanderkiel alexanderkiel added the bug Something isn't working label Jan 29, 2022
@alexanderkiel alexanderkiel added this to the v0.15.4 milestone Jan 29, 2022
@codecov
Copy link

codecov bot commented Jan 30, 2022

Codecov Report

Merging #594 (8df0569) into develop (6536dd6) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #594   +/-   ##
========================================
  Coverage    92.48%   92.48%           
========================================
  Files          233      233           
  Lines        13682    13683    +1     
  Branches       405      405           
========================================
+ Hits         12654    12655    +1     
  Misses         623      623           
  Partials       405      405           
Impacted Files Coverage Δ
modules/fhir-structure/src/blaze/fhir/spec.clj 88.73% <100.00%> (+0.07%) ⬆️

@alexanderkiel alexanderkiel force-pushed the close-inputstream branch 2 times, most recently from 8d10f3f to 2bd620c Compare January 30, 2022 17:20
Versions of Blaze from 0.13.2 to 0.15.3, starting with the migration to
Jetty, had the problem that the JSON parser did not read the entire
inputstream so that terminal chunks could remain, which caused Jetty to
close the stream.
@alexanderkiel alexanderkiel changed the title Close Inputstream of JSON Request Payloads Consume the Whole Inputstream of Request Payloads Jan 30, 2022
@alexanderkiel alexanderkiel merged commit 5a96c2d into develop Jan 30, 2022
@alexanderkiel alexanderkiel deleted the close-inputstream branch January 30, 2022 20:59
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant