Improve Content Negotiation #703
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexanderkiel
added
refactoring
module:rest-api
module:rest-util
enhancement
Codecov Report
@@ Coverage Diff @@
## develop #703 +/- ##
========================================
Coverage 93.64% 93.64%
========================================
Files 237 237
Lines 14156 14173 +17
Branches 356 356
========================================
+ Hits 13256 13272 +16
- Misses 544 545 +1
Partials 356 356
|
Refactored some Ring handlers into the Ring async style, because reitit runs the not-acceptable default handler on nil returning handlers which doesn't work when a future is returned.
alexanderkiel
added a commit
that referenced
this pull request
May 10, 2022
This fixes a regression introduced by #703 where we don't return JSON by default if an Accept header is present. This is relevant in situations where browsers start with text/html but also will accept application/xml with lower priority. Instead of returning a 406 in this cases, XML is delivered now. If one prefers JSON in browsers the _format query param has to be used.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored some Ring handlers into the Ring async style, because reitit runs the not-acceptable default handler on nil returning handlers which doesn't work when a future is returned.