Fix URL Generation #932
Merged
Fix URL Generation #932
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexanderkiel
added
bug
alexanderkiel
force-pushed
the
fix-location-header
branch
2 times, most recently
from
c387c3c
to
7f47142
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #932 +/- ##
===========================================
- Coverage 94.04% 94.03% -0.02%
===========================================
Files 240 240
Lines 15007 14995 -12
Branches 379 380 +1
===========================================
- Hits 14114 14101 -13
Misses 514 514
- Partials 379 380 +1
|
alexanderkiel
force-pushed
the
fix-location-header
branch
from
7f47142
to
cc7b249
Compare
In #925, I changed the implementation of blaze.handler.fhir.util/type-url, instance-url and versioned-instance-url so that I no longer payed attention to the context path. So URL's generated by that functions missed the context-path. Also fixed the Bundle.entry.request.url in history bundles.
alexanderkiel
force-pushed
the
fix-location-header
branch
from
cc7b249
to
f696f62
Compare
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #925, I changed the implementation of blaze.handler.fhir.util/type-url, instance-url and versioned-instance-url so that I no longer payed attention to the context path. So URL's generated by that functions missed the context-path.
Also fixed the Bundle.entry.request.url in history bundles.