Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

combination benchmark #363

Merged
merged 5 commits into from
Jan 31, 2025
Merged

combination benchmark #363

merged 5 commits into from
Jan 31, 2025

Conversation

Annacaro22
Copy link
Contributor

Compute binomial combination, ie. n choose k, for positive integers.

@sampsyo
Copy link
Owner

sampsyo commented Jan 31, 2025

Hello! It looks like the tests are failing because the interpreter couldn't parse the command-line arguments. I think you want ARGS: 1 2 instead of ARGS: 1, 2?

@Annacaro22
Copy link
Contributor Author

My bad! Just fixed that.

@sampsyo
Copy link
Owner

sampsyo commented Jan 31, 2025

Thanks! Now the tests are failing because of the missing .prof output. That can also be generated with turnt --save; can you add that file?

@Annacaro22
Copy link
Contributor Author

Annacaro22 commented Jan 31, 2025

Hmmm, when I run that command, I get the .out file, but no .prof is automatically generated. I have the -p flag in my turnt.toml file. When I run in the command line with the -p flag, I get the total_dyn_inst printed to the terminal, so I'm not sure why it's having trouble making the file through turnt... my turnt.toml file is currently:
command = "bril2json < {filename} | brili {args} -p"
and i run it in the command line with: turnt --save combination.bril

@Annacaro22
Copy link
Contributor Author

I can copy paste it from the terminal into a .prof file? Would that work or no?

@sampsyo
Copy link
Owner

sampsyo commented Jan 31, 2025

You can certainly do it manually. Or you can just use turnt --save and the provided turnt.toml, which is configured to produce this file:

output.prof = "2"

@Annacaro22
Copy link
Contributor Author

That worked! Thank you so much.

@sampsyo
Copy link
Owner

sampsyo commented Jan 31, 2025

Looks good; thanks!

@sampsyo sampsyo merged commit 2ef75a3 into sampsyo:main Jan 31, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants