Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add 2dconv benchmark #385

Open
wants to merge 13 commits into
base: main
Choose a base branch
from
Open

add 2dconv benchmark #385

wants to merge 13 commits into from

Conversation

Jonahcb
Copy link

@Jonahcb Jonahcb commented Feb 1, 2025

No description provided.

@sampsyo
Copy link
Owner

sampsyo commented Feb 1, 2025

Hello! Could you please add the profiling output (.prof file) and a line to the documentation?

@Jonahcb
Copy link
Author

Jonahcb commented Feb 1, 2025

Hello! Could you please add the profiling output (.prof file) and a line to the documentation?

Sorry, but how do I get the .prof file? I don't see it in my directory when I run my program so do I have to do something else to get it? Thank you!

@sampsyo
Copy link
Owner

sampsyo commented Feb 1, 2025

Try turnt --save. The turnt.toml in the benchmarks directory is configured to produce this file:

output.prof = "2"

@Jonahcb
Copy link
Author

Jonahcb commented Feb 1, 2025

Okay, I think I fixed it. Sorry, I haven't used Github much.

@sampsyo
Copy link
Owner

sampsyo commented Feb 2, 2025

OK, looks good so far! Next, I noticed there is some inconsistency in the naming: the files are named 2dconvol, but the documentation refers to 2dconv. Could you please pick one?

@Jonahcb
Copy link
Author

Jonahcb commented Feb 2, 2025

Okay, I fixed it. Sorry about that!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants