go prefixedwriter: fix short write error case #68
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In certain cases, formatting as JSON actually reduces the number of bytes.
This leads to the bufio.Writer that wraps this returning
short write
errorbecause the number of bytes returned is less than expected.
We just want to return the original number of bytes, since we know that we are
doing some string manipulation and we are OK with that.
See: https://pkg.go.dev/io#Writer
how did I test this?
I noticed that sometimes log lines would get lost. with some investigation, i realized that if taskrunner invokes
"should get here" would not be reached because we do the special json formatting which somehow truncates the number of bytes, and we were getting this
short write
error. This was not apparent because we swallow a lot ofWrite()
errors and such, but I don't want to blow up this PR scope with fixing + testing all of those.which lead me down to this investigation path.
after this fix, the log lines get printed properly.