Fix empty output in csv_vectors example #89
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found that
cargo run --example csv_vectors
produced incorrect output:Where, based on the example, I expected:
I believe the
csv::Reader::from_reader
function expects data where each line is a record. However, in the example, all values are on a single line, so the CSV reader treats them as columns of a single record.I adjusted the from_csv function's trait bounds to ensure that T can be both deserialized and converted from a string. I also revamped the CSV parsing using ReaderBuilder for a bit more flexibility.
This new implementation produces the expected output.