Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Psalm Crash by Removing Equals Sign in @param Annotations #26

Merged
merged 2 commits into from
Nov 1, 2024

Conversation

nynka
Copy link
Contributor

@nynka nynka commented Nov 1, 2024

The pull request addresses an issue where the @param annotation for a callable parameter in the src classes causes Psalm to crash in downstream projects. The problem is due to the presence of an equals sign (=) in the annotation. The pull request removes the equals sign to prevent the crash.

Summary of changes:

  • Fixed the @param annotation for the $filter parameter in the classes to remove the equals sign (=).

Details:

  • Updated the @param annotation for the $filter parameter in all affetcted methods to remove the equals sign (=) after int|string|null $key.

This change ensures compatibility with Psalm and prevents it from crashing in downstream projects.

@samsonasik samsonasik merged commit c26a928 into samsonasik:main Nov 1, 2024
0 of 2 checks passed
@samsonasik
Copy link
Owner

Thank you @nynka

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants