This repository has been archived by the owner on Jul 14, 2019. It is now read-only.
Fixes to update for master and worker nodes #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidewatson
approved these changes
Sep 20, 2018
| @@ -21,7 +21,21 @@ const ( | |||
| deleteEventAction = "Delete" | |||
| noEventAction = "" | |||
| // TODO should this move to the cluster controller? | |||
| apiServerPort = 443 | |||
| apiServerPort = 443 | |||
| upgradeControlPlaneCmd = "sudo curl -o /usr/bin/kubeadm -sSL https://dl.k8s.io/release/v%[1]s/bin/linux/amd64/kubeadm && " + | |||
There was a problem hiding this comment.
Would these be easier to read if you used backticks instead of double quotes?
There was a problem hiding this comment.
I'd rather keep quotes, I have two level of quoting (", and ') in some commands.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows kubernetes upgrades from versions 1.10.x to 1.11.x.
I did a slight refactor (getMasterSSHClient) to avoid code duplication.
Upgrade version on the controlplane machine first.
Upgrade each worker node machine version individually.
Wait for each machine to be upgraded before upgrading the next one. You can use kubectl get nodes to see the version of each node. You can also do kubectl describe machine <> --namespace <> to look for a successful Upgrade event:
Events:
Type Reason Age From Message
Normal Created 30m ssh-machine-controller Created Machine ssh-controlplane-mqn7f
Normal Updated 17m ssh-machine-controller Updated Machine ssh-controlplane-mqn7f