Improvements for intel -m32 builds. #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On this platform _mm256_extract_epi64 isn't defined, but the rest of AVX2 is. It needs to fail auto-detection. Also we get unaligned accesses in the SSE4 code with tbuf due to differing data alignment caused by 32-bit pointers instead of 64-bit. This exposes an underlying problem of using aligned SIMD writes on tbuf without explicitly asking for alignment. (The new code is also sometimes a little faster.) See also samtools/htslib#1500
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On this platform _mm256_extract_epi64 isn't defined, but the rest of
AVX2 is. It needs to fail auto-detection.
Also we get unaligned accesses in the SSE4 code with tbuf due to
differing data alignment caused by 32-bit pointers instead of 64-bit.
This exposes an underlying problem of using aligned SIMD writes on
tbuf without explicitly asking for alignment. (The new code is also
sometimes a little faster.)
See also samtools/htslib#1500