Add hts_flush() API function #1326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
valeriuo
approved these changes
Sep 1, 2021
|
A NEWS entry about these interfaces would be appreciated. |
Implemented by calling through to the various underlying flush routines. Also add sam_flush() and bcf_flush() wrappers.
|
NEWS entry added, along with adding |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The various underlying file types provide flush routines, but
htsFileto date does not.Also add
sam_flush()andbcf_flush()wrappers. There was a temptation to make thesestatic inlinefunctions, but instead I followed the existing pattern forsam_*andbcf_*wrappers ofhts_*functions via#define.This API function is needed by an upcoming samtools PR that wants to flush a
samFile.