-Wdouble-promotion clean API
#1365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for raising this. We'll discuss it on our weekly meeting (Tuesday). Fixing the whole code base is probably quite an undertaking and I'm not sure we really wish to have the maintenance overhead of avoiding automatic float to double promotion everywhere (I count 81 one of them, and likely many more in samtools/bcftools if we touch those), but if this is all that's needed for your work then it seems reasonable to me. |
jkbonfield
reviewed
Dec 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a GPU codebase that we use with htslib where we have to be very careful with
float<->doubleconversions, for which we enable-Wdouble-promotion. Unfortunately, the publicly facing API has two lines that trigger this, mainly due to the fact thatprintfdoesn't have float specifiers. This PR has two commits:-Wdouble-promotionclean by adding explicit casts.-Wdouble-promotionissue. This one can be dropped, but it's not very invasive.I tried fixing the whole codebase, but this required more casts. If desired, I can do those too.