Detect ARM Neon support and only build appropriate SIMD object files #1451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add test compilations to detect ARM Neon support to configure.ac and hts_probe_cc.sh. If compiler support is present, add rANS_static32x16pr_neon.c to $(HTSCODECS_SOURCES) in htscodecs_bundled.mk. Fixes samtools#1450. In htscodecs_bundled.mk, only add rANS_static32x16pr_avx2.c et al to $(HTSCODECS_SOURCES) if the respective AVX2, AVX512, SSE4 support is present. As building these files already uses GNU Make-specific constructs and the $(HTS_CFLAGS_AVX2) variables are either empty or an option string, this is easily achieved via `$(if $(HTS_CFLAGS_AVX2),...)`. There is no compiler flag required for Neon, so invent HTS_HAVE_NEON and use it to control building rANS_static32x16pr_neon.c without adding any bespoke compilation options for it.
|
Well, that worked better than my effort, which discovered that empty translation units are not allowed in pedantic mode. Would you mind if I pushed a commit here to add an ARM CI test? |
|
No worries, go ahead. |
|
Cheers. I will once I've tuned it up suitably. Sadly going for Address Sanitizer looks like it was a step too far. It seems to be really slow on arm. |
Tries to be as strict as possible. Unfortunately Address Sanitizer appears to be very slow on this platform at the moment, so has been left out for now. It would be good to add it later should its performance improve.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add test compilations to detect ARM Neon support to configure.ac and hts_probe_cc.sh. If compiler support is present, add rANS_static32x16pr_neon.c to
$(HTSCODECS_SOURCES)in htscodecs_bundled.mk. Fixes #1450.Similarly only add rANS_static32x16pr_avx2.c et al to
$(HTSCODECS_SOURCES)if the respective AVX2, AVX512, SSE4 support is present. As building these files already uses GNU Make-specific constructs (namely target-specific variables in Makefile) and the$(HTS_CFLAGS_AVX2)Make variables already exist and are either empty or a non-empty option string, this is easily achieved via$(if $(HTS_CFLAGS_AVX2),...).There is no compiler flag required for Neon, so invent
HTS_HAVE_NEONand use it to control building rANS_static32x16pr_neon.c without adding any bespoke compilation options for it.