Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Popover Panel to be hidden #49

Merged
merged 2 commits into from
Feb 12, 2023
Merged

Fix Popover Panel to be hidden #49

merged 2 commits into from
Feb 12, 2023

Conversation

longtran1904
Copy link
Contributor

@longtran1904 longtran1904 commented Feb 7, 2023 •
edited
Loading

Let Popover to be hidden when window is expanded

@samuel-ping samuel-ping self-requested a review February 7, 2023 20:51
samuel-ping
samuel-ping requested changes Feb 8, 2023
View reviewed changes
Copy link
Owner

@samuel-ping samuel-ping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow this was something I never would have looked for. Also thanks for the PR!

src/components/Navbar.js Show resolved Hide resolved
@samuel-ping samuel-ping merged commit 52df418 into samuel-ping:main Feb 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samuel-ping samuel-ping samuel-ping requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@longtran1904 @samuel-ping