Feat add IsHash #44

osintalex · 2022-06-19T20:05:29Z

I've kept very simple since this is all I'd want to use to save time in tests and imagined I'd probably want to define a custom regex for most other hashes using IsStr. Just my two cents though.

codecov · 2022-06-19T20:06:17Z

Codecov Report

Merging #44 (aa706fc) into main (5cf23ce) will not change coverage.
The diff coverage is 100.00%.

Additional details and impacted files

@@            Coverage Diff            @@
##              main       #44   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           12        12           
  Lines          692       709   +17     
  Branches       176       180    +4     
=========================================
+ Hits           692       709   +17

Impacted Files	Coverage Δ
dirty_equals/__init__.py	`100.00% <100.00%> (ø)`
dirty_equals/_other.py	`100.00% <100.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5cf23ce...aa706fc. Read the comment docs.

dirty_equals/_other.py

tests/test_other.py

samuelcolvin · 2022-06-24T11:32:41Z

Otherwise looking good.

osintalex · 2022-06-25T17:11:29Z

Ready for review ☺️

samuelcolvin

also conflicts with your other PR, otherwise LGTM.

samuelcolvin · 2022-08-26T10:45:47Z

dirty_equals/_other.py

+        Args:
+            hash_type: The hash type to check. Must be specified.
+
+        ```py title="IsUUID"


Suggested change

```py title="IsUUID"

```py title="IsHash"

samuelcolvin · 2022-08-26T10:46:56Z

dirty_equals/_other.py

+            'md5': r'^[a-fA-F\d]{32}$',
+            'sha-1': r'^[a-fA-F\d]{40}$',
+            'sha-256': r'^[a-fA-F\d]{64}$',


Suggested change

'md5': r'^[a-fA-F\d]{32}$',

'sha-1': r'^[a-fA-F\d]{40}$',

'sha-256': r'^[a-fA-F\d]{64}$',

'md5': r'[a-fA-F\d]{32}',

'sha-1': r'[a-fA-F\d]{40}',

'sha-256': r'[a-fA-F\d]{64}',

Since you're using fullmatch

dirty_equals/_other.py

samuelcolvin · 2022-08-26T10:48:04Z

dirty_equals/_other.py

+    A class that checks if a value is a valid common hash type, using a simple length and allowed characters regex.
+    """
+
+    def __init__(self, hash_type: Literal['md5', 'sha-1', 'sha-256']):


Suggested change

def __init__(self, hash_type: Literal['md5', 'sha-1', 'sha-256']):

def __init__(self, hash_type: HashTypes):

samuelcolvin · 2022-08-26T10:48:24Z

dirty_equals/_other.py

+        allowed_hashes = 'md5', 'sha-1', 'sha-256'
+        if hash_type not in allowed_hashes:


Suggested change

allowed_hashes = 'md5', 'sha-1', 'sha-256'

if hash_type not in allowed_hashes:

if hash_type not in HashTypes.__args__:

That's neat! Didn't know you could do that

samuelcolvin · 2022-09-02T19:10:47Z

conflicts too.

osintalex · 2022-09-02T19:32:01Z

Think that's all your changes and conflicts gone, let me know if I missed anything.

samuelcolvin · 2022-09-15T11:08:20Z

Thanks so much @osintalex, I'll make a new release now.

samuelcolvin · 2022-09-15T11:10:00Z

~~I'll make a new release now~~ cancel that, I'll make a release once #47 is merged.

Feat add IsHash

04bae23

samuelcolvin reviewed Jun 24, 2022

View reviewed changes

dirty_equals/_other.py Outdated Show resolved Hide resolved

dirty_equals/_other.py Outdated Show resolved Hide resolved

dirty_equals/_other.py Outdated Show resolved Hide resolved

dirty_equals/_other.py Outdated Show resolved Hide resolved

tests/test_other.py Show resolved Hide resolved

fix IsHash logic and add hashlib tests

00e5a6b

samuelcolvin reviewed Aug 26, 2022

View reviewed changes

osintalex added 2 commits September 2, 2022 20:13

Fix use HashTypes variable and regex tweaks

d227f84

Merge branch 'main' into add-ishash

1c13be9

allow bytes, fix literal check

aa706fc

samuelcolvin merged commit 42c5594 into samuelcolvin:main Sep 15, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feat add IsHash #44

Feat add IsHash #44

osintalex commented Jun 19, 2022 •

edited

Loading

codecov bot commented Jun 19, 2022 •

edited

Loading

samuelcolvin commented Jun 24, 2022

osintalex commented Jun 25, 2022

samuelcolvin left a comment

samuelcolvin Aug 26, 2022

samuelcolvin Aug 26, 2022

samuelcolvin Aug 26, 2022

samuelcolvin Aug 26, 2022

osintalex Sep 2, 2022

samuelcolvin commented Sep 2, 2022

osintalex commented Sep 2, 2022

samuelcolvin commented Sep 15, 2022

samuelcolvin commented Sep 15, 2022

	def __init__(self, hash_type: Literal['md5', 'sha-1', 'sha-256']):
	def __init__(self, hash_type: HashTypes):

		allowed_hashes = 'md5', 'sha-1', 'sha-256'
		if hash_type not in allowed_hashes:

	allowed_hashes = 'md5', 'sha-1', 'sha-256'
	if hash_type not in allowed_hashes:
	if hash_type not in HashTypes.__args__:

Feat add IsHash #44

Feat add IsHash #44

Conversation

osintalex commented Jun 19, 2022 • edited Loading

codecov bot commented Jun 19, 2022 • edited Loading

Codecov Report

samuelcolvin commented Jun 24, 2022

osintalex commented Jun 25, 2022

samuelcolvin left a comment

Choose a reason for hiding this comment

samuelcolvin Aug 26, 2022

Choose a reason for hiding this comment

samuelcolvin Aug 26, 2022

Choose a reason for hiding this comment

samuelcolvin Aug 26, 2022

Choose a reason for hiding this comment

samuelcolvin Aug 26, 2022

Choose a reason for hiding this comment

osintalex Sep 2, 2022

Choose a reason for hiding this comment

samuelcolvin commented Sep 2, 2022

osintalex commented Sep 2, 2022

samuelcolvin commented Sep 15, 2022

samuelcolvin commented Sep 15, 2022

osintalex commented Jun 19, 2022 •

edited

Loading

codecov bot commented Jun 19, 2022 •

edited

Loading