-
-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Python 3.12 support, drop Python 3.7 support #248
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #248 +/- ##
=======================================
Coverage 99.51% 99.51%
=======================================
Files 6 6
Lines 416 416
Branches 82 82
=======================================
Hits 414 414
Misses 1 1
Partials 1 1 Continue to review full report in Codecov by Sentry.
|
@samuelcolvin I'm not sure why the failing test on linux (seems flaky?).. Regarding everything else let me know your comments/objections :) |
looks good to me, but I would say, given it's the same test failing every time, that there is something wrong. |
@samuelcolvin yeah, the strange thing to me is that is passing only on stable rust and py 3.11. |
@samuelcolvin probably it was the scanning of |
Awesome, thank you. I'll do a release today. |
Changes summary