Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Containers which have console specified don't actually get a console set as controlling #9

Closed
gizahNL opened this issue Jun 2, 2021 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@gizahNL
Copy link
Contributor

gizahNL commented Jun 2, 2021

FreeBSD requires a process to be session leader of it's process group and requires the TIOCSTTY ioctl to be called on the console FD to actually set the console as controlling.
Before:

root@mergusserator:~/go/src/go.sbk.wtf/runj # ctr run --runtime wtf.sbk.runj.v1 --tty --rm public.ecr.aws/samuelkarp/freebsd:12.1-RELEASE testjail /bin/csh
Warning: no access to tty (Bad file descriptor).
Thus no job control in this shell.
# 

After:

root@mergusserator:/var/lib # ctr run --runtime wtf.sbk.runj.v1 --tty --rm public.ecr.aws/samuelkarp/freebsd:12.1-RELEASE testjail /bin/csh
#
@samuelkarp samuelkarp added the bug Something isn't working label Jun 2, 2021
@samuelkarp
Copy link
Owner

Thanks for the bug report. I hadn't seen this before, but I had also been executing /bin/sh rather than /bin/csh.

@samuelkarp
Copy link
Owner

Resolved by #10.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants