Properly set the controlling console #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tianon
reviewed
Jun 2, 2021
cmd/runj-entrypoint/main.go
Outdated
| } | ||
|
|
||
| if ret, _, err := unix.Syscall(unix.SYS_IOCTL, uintptr(fd), unix.TIOCSCTTY, uintptr(0)); ret != 0 || err != 0 { | ||
| return fmt.Errorf("Unable to set controlling tty") |
There was a problem hiding this comment.
Wouldn't it make sense to do something with ret and/or err here depending on which condition got us to this point?
(For example, isn't err going to be an error object? Meaning it could be wrapped with something like fmt.Errorf("Unable to set controlling tty: %w", err)?)
There was a problem hiding this comment.
Yes I should ;) err is an errno, and that could be wrapped as well.
I think ret is actually safe to ignore, because I think errno would always be set when ret would be non zero
There was a problem hiding this comment.
I went with returning err instead of formatting, as that is what the rest of that function does as well.
For FreeBSD it's required to become session leader of the process group before a console can be set as controlling, furthermore it's required to call TIOCSTTY on the console FD to actually set it as controlling.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number:
#9
Description of changes:
Call setsid to create a new session and make the calling process the session leader, then call the SIOCSTTY ioctl on the console FD to set it as the controlling console.
Testing done:
CLI testing as is documented in the issue
Terms of contribution:
By submitting this pull request, I agree that this contribution is licensed under the terms found in the LICENSE file.