Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix runj demo oci-image #34

Merged
merged 1 commit into from
Sep 19, 2022

Conversation

kit-ty-kate
Copy link
Contributor

@kit-ty-kate kit-ty-kate commented Sep 12, 2022

Fixes #33

See https://github.com/opencontainers/image-spec/blob/bc9c4bd9b2a4ec6f49f956e193f9c699d854507d/image-layout.md#blobs for the spec

Terms of contribution:

By submitting this pull request, I agree that this contribution is licensed under the terms found in the LICENSE file.

@samuelkarp
Copy link
Owner

Well that's embarrassing.

@kit-ty-kate I see that you deleted the pull request template. Can you affirm that your contribution is licensed under the terms found in the LICENSE file?

@kit-ty-kate
Copy link
Contributor Author

Ah, sure. I added the "terms of contribution" section back

@kit-ty-kate
Copy link
Contributor Author

kit-ty-kate commented Sep 13, 2022

Side note on the template: the link to the LICENSE file does not redirect to the right file. Currently it links to https://github.com/LICENSE instead of https://github.com/samuelkarp/runj/blob/main/LICENSE as per your comment. Maybe the output is different when you’re the owner of the repository compared to contributers?

The output is also the same for other people so it’s not just me. For example see: #31

Copy link
Owner

@samuelkarp samuelkarp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@samuelkarp samuelkarp merged commit 3bc60d3 into samuelkarp:main Sep 19, 2022
@samuelkarp
Copy link
Owner

Side note on the template: the link to the LICENSE file does not redirect to the right file.

Thanks, fixed in ec642aa.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

runj demo oci-image generates an image that buildah can't parse
2 participants