Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to rails 6.1 #5786

Merged
merged 9 commits into from
Sep 6, 2022
Merged

Upgrade to rails 6.1 #5786

merged 9 commits into from
Sep 6, 2022

Conversation

cjcolvar
Copy link
Member

@cjcolvar cjcolvar commented Jul 27, 2022

Upgrade hyrax to Rails 6.1. For the most part only small fixes were needed as supporting samvera core components already have support for Rails 6.1.

TODO: Upgrade dassie to Rails 6.1

@cjcolvar cjcolvar force-pushed the cjcolvar-patch-2 branch 3 times, most recently from f19e855 to 9bbd8d3 Compare August 10, 2022 17:59
@cjcolvar cjcolvar force-pushed the cjcolvar-patch-2 branch 3 times, most recently from b358647 to 3a49286 Compare August 12, 2022 19:51
@cjcolvar cjcolvar marked this pull request as ready for review August 31, 2022 15:39
@cjcolvar cjcolvar changed the title Test with rails 6.1 Upgrade to rails 6.1 Aug 31, 2022
Copy link
Member

@dlpierce dlpierce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not noticing any difficulty running Dassie with Rails 6.1, and its Gemfile doesn't preclude it either. Everything seems to still work under Rails 6.0 too.

@cjcolvar cjcolvar merged commit 27bc572 into main Sep 6, 2022
@cjcolvar cjcolvar deleted the cjcolvar-patch-2 branch September 6, 2022 13:11
@dlpierce dlpierce added the notes-minor Release Notes: Non-breaking features label Oct 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
notes-minor Release Notes: Non-breaking features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants