Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#5798 Valkyrie: Show all collection descriptive metadata #6103

Merged
merged 5 commits into from
Jun 30, 2023

Conversation

summer-cook
Copy link
Contributor

@summer-cook summer-cook commented Jun 29, 2023

Fixes

Summary

All attributes were not being indexed for Valkryrie collections. This PR makes sure all attributes that are intentionally being added to collections are being indexed, and that they all appear on the collection show page & in the dashboard. It also ensures that indexing still functions correctly in regular Hyrax.

Type of change (for release notes)

  • notes-valkyrie Valkyrie Progress

Changes proposed in this pull request:

  • Enable indexing for Valkyrie collections
  • Since the rationale of this ticket says "Descriptive metadata fields on collection are the same as on Works by default and while this may not be how collection metadata often works, it seems the best way to manage descriptive metadata for application development purposes." meaning that collections should have all the same basic metadata as works, add basic metadata indexing to the collections
  • Enables display of all collection metadata on the Collection show page & in the dashboard

Screenshots

Metadata working on both collection show & dashboard page Screen Shot 2023-06-29 at 16 45 02 Screen Shot 2023-06-29 at 16 49 27

@samvera/hyrax-code-reviewers

@summer-cook summer-cook added the notes-valkyrie Release Notes: Valkyrie specific label Jun 29, 2023
@summer-cook summer-cook marked this pull request as ready for review June 29, 2023 21:18
alishaevn
alishaevn previously approved these changes Jun 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
notes-valkyrie Release Notes: Valkyrie specific
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show all collection descriptive metadata
3 participants