Accounts for Koppie's config in spec/models/flipflop_spec.rb.
#6603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlpierce
approved these changes
Jan 11, 2024
jeremyf
added a commit
that referenced
this pull request
Jan 19, 2024
* main: (264 commits) #5098 Valkyrize FileSet Generator Converts collection in spec/features/collection_type_spec.rb and highlights bug. Valkyrizes spec/views/hyrax/batch_edits/edit.html.erb_spec.rb. Accounts for Valkyrie's schema parsing dates differently in spec/hyrax/schema_spec.rb. Edit work_form_helper_spec.rb Marks spec/forms/hyrax/forms/batch_edit_form_spec.rb as ActiveFedora-only. Adds switch for expected solr cor in spec/valkyrie/indexing/solr/indexing_adapter_spec.rb. Corrects spec/search_builders/hyrax/my/collections_search_builder_spec.rb after environment behaviors correction. Marks spec/presenters/hyrax/member_presenter_factory_spec.rb as ActiveFedora-only. Edit iiif_manifest_cache_prewarm_job_spec.rb Edit create_work_admin_spec.rb Valkyrizes spec/services/hyrax/embargo_service_spec.rb. Accounts for Koppie's config in `spec/models/flipflop_spec.rb`. (#6603) Valkyrizes spec/features/iiif_manifest_spec.rb. Edit sipity_spec.rb Edit move_all_works_to_admin_set_spec.rb Edit work_query_service_spec.rb Marks spec/models/concerns/hyrax/solr_document/ordered_members_spec.rb as ActiveFedora-only. Makes `spec/services/hyrax/valkyrie_upload_spec.rb` friendly for both Koppie and Dassie. (#6591) Valkyrizes spec/features/dashboard/my_works_spec.rb. ...
jeremyf
added a commit
that referenced
this pull request
Jan 19, 2024
* main: (264 commits) #5098 Valkyrize FileSet Generator Converts collection in spec/features/collection_type_spec.rb and highlights bug. Valkyrizes spec/views/hyrax/batch_edits/edit.html.erb_spec.rb. Accounts for Valkyrie's schema parsing dates differently in spec/hyrax/schema_spec.rb. Edit work_form_helper_spec.rb Marks spec/forms/hyrax/forms/batch_edit_form_spec.rb as ActiveFedora-only. Adds switch for expected solr cor in spec/valkyrie/indexing/solr/indexing_adapter_spec.rb. Corrects spec/search_builders/hyrax/my/collections_search_builder_spec.rb after environment behaviors correction. Marks spec/presenters/hyrax/member_presenter_factory_spec.rb as ActiveFedora-only. Edit iiif_manifest_cache_prewarm_job_spec.rb Edit create_work_admin_spec.rb Valkyrizes spec/services/hyrax/embargo_service_spec.rb. Accounts for Koppie's config in `spec/models/flipflop_spec.rb`. (#6603) Valkyrizes spec/features/iiif_manifest_spec.rb. Edit sipity_spec.rb Edit move_all_works_to_admin_set_spec.rb Edit work_query_service_spec.rb Marks spec/models/concerns/hyrax/solr_document/ordered_members_spec.rb as ActiveFedora-only. Makes `spec/services/hyrax/valkyrie_upload_spec.rb` friendly for both Koppie and Dassie. (#6591) Valkyrizes spec/features/dashboard/my_works_spec.rb. ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Fixes
spec/models/flipflop_spec.rb.Summary
Accounts for Koppie's config in
spec/models/flipflop_spec.rb.Type of change (for release notes)
notes-valkyrieValkyrie Progress@samvera/hyrax-code-reviewers