Do not require custom cops in the engine

[dlpierce]

This broke builds that do not install the rubocop gem. Loading of this custom cop is handled by rubocop.yml

Fixes

Nurax failing to build due to rubocop gem not included.

[kirkkwang]

Ah sorry about that, didn't think of that case!

[kirkkwang]

Oh right there are specs that looked for the dirty cops

[github-actions]

Test Results

    17 files  ±0      17 suites  ±0   2h 22m 55s ⏱️ + 6m 5s
 6 705 tests ±0   6 408 ✅ ±0  297 💤 ±0  0 ❌ ±0 
13 178 runs  ±0  12 783 ✅ ±0  395 💤 ±0  0 ❌ ±0 

Results for commit 1924db5. ± Comparison against base commit b98d6f4.

This pull request removes 275 and adds 275 tests. Note that renamed tests count towards both.

spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007f58820380e0>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007fb4496fc1d8>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007f58820eb2d0>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007fb4496f0658>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy AdminSet: 8a1f39d9-bc3a-4ae4-a3f2-1380b10bca12
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy Hyrax::AdministrativeSet: 56284073-4232-4dce-aae1-ae4b203eedab
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to edit AdminSet: b7b48c53-8854-42aa-9387-c54f47c1ced1
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to edit Hyrax::AdministrativeSet: 4fad2485-9d7d-472f-bae3-63a6239380ab
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to update AdminSet: f11f6391-4f45-4605-acb8-a7fe16182c8b
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to update Hyrax::AdministrativeSet: f0af38f7-8038-431f-b67b-d690a0f13ed2
…

spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007f20af43a518>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007f797633d488>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007f20af6ddae0>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007f797f682950>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy AdminSet: f6dd002a-0c3a-4e85-ab49-e767863ddfa4
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy Hyrax::AdministrativeSet: a8fbab0e-8b2b-4ad6-a76e-5d16e3785573
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to edit AdminSet: 21b319e2-07df-4891-ab5d-a33d2dcf29b0
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to edit Hyrax::AdministrativeSet: 0874ee36-1196-4c6b-9a57-408ef9475a1b
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to update AdminSet: 24154c30-861d-4b34-a1a4-c7fdb8ffc1bd
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to update Hyrax::AdministrativeSet: af277d23-fb71-46e8-8aeb-f841090eb073
…

♻️ This comment has been updated with latest results.

[dlpierce]

I forgot there was a spec for the cop.