-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing concurrent-ruby incompatibility with version bump #7002
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1.3.5 exposes rails bug that is fixed in rails 7
Test Results 13 files ±0 13 suites ±0 2h 54m 40s ⏱️ + 3m 9s Results for commit 597e077. ± Comparison against base commit bc7a2b6. This pull request removes 360 and adds 365 tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
dlpierce
previously approved these changes
Feb 3, 2025
597e077
to
a8d9124
Compare
a8d9124
to
597e077
Compare
cjcolvar
approved these changes
Feb 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While trying to release v5.0.2 containing all changes up to the Ruby/Rails upgrade, it was discovered that Hyrax would potentially not build because of an issue with
concurrent-ruby
. This was addressed during that upgrade, so we're just cherry-picking and adding ec36aca so we can release v5.0.3.