Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing concurrent-ruby incompatibility with version bump #7002

Merged
merged 2 commits into from
Feb 4, 2025

Conversation

randalldfloyd
Copy link
Contributor

While trying to release v5.0.2 containing all changes up to the Ruby/Rails upgrade, it was discovered that Hyrax would potentially not build because of an issue with concurrent-ruby. This was addressed during that upgrade, so we're just cherry-picking and adding ec36aca so we can release v5.0.3.

dlpierce and others added 2 commits January 31, 2025 15:52
Copy link

github-actions bot commented Feb 3, 2025

Test Results

    13 files  ±0      13 suites  ±0   2h 54m 40s ⏱️ + 3m 9s
 6 838 tests +5   6 539 ✅ +5  299 💤 ±0  0 ❌ ±0 
18 101 runs  ±0  17 624 ✅ ±0  477 💤 ±0  0 ❌ ±0 

Results for commit 597e077. ± Comparison against base commit bc7a2b6.

This pull request removes 360 and adds 365 tests. Note that renamed tests count towards both.
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007f5123adde98>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007f55e6ac99d0>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007f6d1945d5c0>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007f5124832940>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007f55e5a02318>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007f6d19468858>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy AdminSet: 667b1152-d707-4085-a5c0-eddf74b62be9
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy Hyrax::AdministrativeSet: 614af7e3-2524-4bd7-8faf-ac1b7a784367
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy Hyrax::AdministrativeSet: 918d539a-f73b-4bcd-bb41-084d44977752
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to edit AdminSet: 74c1ca2c-ef8b-41bc-96ee-096b76cb20ef
…
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007f6578a8c458>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007fa78b1d6908>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007fb20817b2d8>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007f6578962460>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007fa78c869ee0>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007fb2081902a0>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy AdminSet: 7ecbf488-a99a-4fc3-bb78-a251f234a751
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy Hyrax::AdministrativeSet: 2205055d-0082-4bb4-80e9-82c4969fbcdd
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy Hyrax::AdministrativeSet: 5bd6ead7-782d-4eef-a41e-9bba51fa1222
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to edit AdminSet: a386d582-7341-4846-a5d5-8d161ef1d603
…

♻️ This comment has been updated with latest results.

dlpierce
dlpierce previously approved these changes Feb 3, 2025
@randalldfloyd randalldfloyd merged commit 21c5420 into main Feb 4, 2025
20 of 21 checks passed
@randalldfloyd randalldfloyd deleted the main_before_rails_72 branch February 4, 2025 16:01
@randalldfloyd randalldfloyd restored the main_before_rails_72 branch February 4, 2025 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants