Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timezone Aware #13

Merged
merged 2 commits into from
Sep 14, 2023
Merged

Timezone Aware #13

merged 2 commits into from
Sep 14, 2023

Conversation

simonwiles
Copy link
Contributor

This is an attempt at resolving #12; I have little experience with rust, but just depending on the chrono crate was very straightforward and seems to work great on all the systems I've tried it on.

Does this look like it might be acceptable? What more would you want to see to consider merging something like this?

Thanks!

@samwho
Copy link
Owner

samwho commented Sep 14, 2023

This looks great to me.

In the beginning I did use chrono, but decided to get rid of it and rely directly on time because chrono, at the time (ha!), was depending on an old version of time that had some security advisories against it. It would appear they have fixed this in recent releases, so we can depend on it again 🥳

Thanks so much for your efforts on spacer, I greatly appreciate them.

@samwho samwho merged commit 44caa0a into samwho:main Sep 14, 2023
@simonwiles simonwiles deleted the timezone-aware branch September 14, 2023 06:20
@simonwiles
Copy link
Contributor Author

Terrific, thanks! I find I'm using spacer all the time, and I'm delighted to be able to contribute a little 😁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants