Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix padding off by one #15

Merged
merged 2 commits into from
Sep 14, 2023
Merged

Fix padding off by one #15

merged 2 commits into from
Sep 14, 2023

Conversation

simonwiles
Copy link
Contributor

Fixes #14

@samwho
Copy link
Owner

samwho commented Sep 12, 2023

Hey @simonwiles! Thanks for pointing this out and producing a PR. Would you be able to add some tests for this? 🙏

@simonwiles
Copy link
Contributor Author

Sure thing. I'm going to have to do some work to understand how the testing system works first, so it might take me a short while 🙂👍️

@simonwiles
Copy link
Contributor Author

Will something like this be adequate?

@samwho
Copy link
Owner

samwho commented Sep 14, 2023

This is perfect! 🙏

@samwho samwho merged commit 040306c into samwho:main Sep 14, 2023
@simonwiles simonwiles deleted the fix-14 branch September 14, 2023 06:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Padding is off by one
2 participants
@simonwiles @samwho