Timezone Selection #16

simonwiles · 2023-09-14T20:23:59Z

Okay, here's a (tested) implementation of a --timezone argument that accepts IANA timezone names in the America/Los_Angeles style. Here it is running on a server in Germany:

$ while true; do date; sleep 2; done | spacer --timezone America/Los_Angeles
Wed 13 Sep 21:02:40 CEST 2023
2023-09-13 12:02:41 PDT 1.0s ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
Wed 13 Sep 21:02:42 CEST 2023
2023-09-13 12:02:43 PDT 2.0s ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
Wed 13 Sep 21:02:44 CEST 2023
2023-09-13 12:02:45 PDT 2.0s ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
Wed 13 Sep 21:02:46 CEST 2023
2023-09-13 12:02:47 PDT 2.0s ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
...

Submitted for your consideration.

Closes #12.

Only if `--timezone` is passed (otherwise format is unchanged). Note: `DateTime<Tz>.format("%Z")` outputs, e.g., "PDT"; `DateTime<Local>.format("%Z")` outputs, e.g., "-07:00".

Tests need updating to account for new command-line argument (new functionality is not tested).

Cargo.toml

samwho · 2023-09-17T17:58:00Z

Just the one small change requested. Thank you for your contributions to spacer! 🙏

Elected to add test for a specific timezone, rather than merely for "a timezone" -- seems like a better test.

simonwiles · 2023-09-18T16:59:55Z

Thank you! This small change makes this super-useful little tool even more chef's kiss for me 🙂

simonwiles added 4 commits September 14, 2023 07:13

Add dependency on chrono-tz crate

1646e72

Initial implementation of optional --timezone argument

15dda83

Add timezone to output string when not system's local time

5ada3f2

Only if `--timezone` is passed (otherwise format is unchanged). Note: `DateTime<Tz>.format("%Z")` outputs, e.g., "PDT"; `DateTime<Local>.format("%Z")` outputs, e.g., "-07:00".

Update tests

0f76a78

Tests need updating to account for new command-line argument (new functionality is not tested).

samwho reviewed Sep 17, 2023

View reviewed changes

Cargo.toml Outdated Show resolved Hide resolved

simonwiles added 3 commits September 18, 2023 09:48

Add the regex crate (for use in tests)

812d473

Add tests for the --timezone flag

ba38604

Elected to add test for a specific timezone, rather than merely for "a timezone" -- seems like a better test.

Better handling of unparsable --timezone values

c9c7dc6

simonwiles force-pushed the timezone-selection branch from 261b047 to c9c7dc6 Compare September 18, 2023 16:48

samwho approved these changes Sep 18, 2023

View reviewed changes

samwho merged commit 7870c1f into samwho:main Sep 18, 2023
13 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Timezone Selection #16

Timezone Selection #16

simonwiles commented Sep 14, 2023

samwho commented Sep 17, 2023

simonwiles commented Sep 18, 2023 •

edited

Loading

Timezone Selection #16

Timezone Selection #16

Conversation

simonwiles commented Sep 14, 2023

samwho commented Sep 17, 2023

simonwiles commented Sep 18, 2023 • edited Loading

simonwiles commented Sep 18, 2023 •

edited

Loading