Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump some dependencies #22

Closed
wants to merge 2 commits into from
Closed

bump some dependencies #22

wants to merge 2 commits into from

Conversation

tacman
Copy link
Contributor

@tacman tacman commented May 31, 2024

I took a first pass at bumping the dependencies (including the phpflickr library!)

Tests fail, because the "name" attribute is missing. But really tests should bump to phpunit 11, which I think now supports attributes.

Guzzle is outdated, but rather than update it, what do you think of switching to the Symfony HttpClient?

@samwilson samwilson mentioned this pull request Jun 3, 2024
@samwilson
Copy link
Owner

I think all updates here are now done by #21, so this can be closed.

Guzzle is outdated, but rather than update it, what do you think of switching to the Symfony HttpClient?

That sounds fine I guess, but I'm not sure what the difference would really be. The latest Guzzle release was six months ago, and it's a pretty stable project. What would be the advantage in using symfony/http-client?

@samwilson samwilson closed this Jun 13, 2024
@tacman
Copy link
Contributor Author

tacman commented Jun 13, 2024

Since this is a stand-alone application, there's really no benefit.

But if this were part of a bundle, then it would make sense that the user could choose their http client. I like Symfony's because of the logging and built-in retry and throttling.

@samwilson
Copy link
Owner

That's a good point.

PhpFlickr uses carlos-mg89/oauth to make HTTP requests, which uses its own HTTP client; it'd be cool to make that injectable.

I must admit, I'm still not completely sure why you want to integrate this app into another app. Is the other app something general, or is it adding functionality that perhaps could be added here?

@tacman
Copy link
Contributor Author

tacman commented Jun 15, 2024

Having worked with this and your library for a while now, I have a better understanding. A bundle is a good solution for me that incorporates some of the functionality here with my application.

So it's not integrating this app with another app, but integrating some of the functionality. Anyway, I'll cherry-pick the stuff I need most into the bundle.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants