Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove Function.name polyfill #142

Closed
wants to merge 1 commit into from

Conversation

davidchambers
Copy link
Member

Function.name has been widely supported for years at this point, so the polyfill no longer seems necessary.

@davidchambers davidchambers requested a review from a team August 19, 2020 18:11
Copy link
Member

@Bradcomp Bradcomp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:bowtie:
I don't know how important IE compatibility is for you, but even IE 11 doesn't support Function.name. It looks like they are certainly moving away from IE support though https://techcommunity.microsoft.com/t5/microsoft-365-blog/microsoft-365-apps-say-farewell-to-internet-explorer-11-and/ba-p/1591666

@davidchambers
Copy link
Member Author

Good point, Brad. My understanding is that there is no way for a user to ensure that typeRep.name evaluates as intended in browsers that do not support this language feature. This change is actually more breaking than adopting const and =>, as those language features can be transpiled to ES5.

Perhaps this pull request should wait a few years. What do others think?

@Avaq
Copy link
Member

Avaq commented Aug 24, 2020

Perhaps this pull request should wait a few years. What do others think?

Since the name is central to the design of this lib, I guess it'd be good to keep the polyfill around until we're certain it's no longer needed.

@davidchambers
Copy link
Member Author

Let's revisit this in a few years. :)

@davidchambers davidchambers deleted the davidchambers/function-name branch August 24, 2020 10:38
@davidchambers davidchambers mentioned this pull request Apr 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants