Respect constraints on type class implementations #145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avaq
force-pushed
the
avaq/constraints
branch
4 times, most recently
from
9432bc5 to
697565f
Compare
Avaq
force-pushed
the
avaq/constraints
branch
2 times, most recently
from
d5e9534 to
8996d1c
Compare
davidchambers
force-pushed
the
avaq/constraints
branch
from
d7419f6 to
f64efdb
Compare
davidchambers
force-pushed
the
avaq/constraints
branch
from
432622b to
53b5571
Compare
index.js
Outdated
| (function() { | ||
| var $seen = []; | ||
| return function(x) { | ||
| // if ($seen.includes (x)) return true; |
There was a problem hiding this comment.
I don't think this code path can be exercised without the changes in the following commit. I think npm test should pass for every new commit on master, so I commented out this line and uncommented it in the following commit.
index.js
Outdated
Comment on lines
297
to
298
| // if ($seen.includes (x)) return true; | ||
| if ($seen.includes (x)) return true; |
There was a problem hiding this comment.
I uncommented this line as the code path can now be exercised. :)
davidchambers
force-pushed
the
avaq/constraints
branch
from
53b5571 to
b51561e
Compare
This will be used in the following commit(s).
Now that getPrototypeMethod calls into user functions (via prototypeMethod), it's possible for these functions to call back into the same test function with the same value - and they will.
davidchambers
force-pushed
the
avaq/constraints
branch
from
b51561e to
2a4e265
Compare
|
Doctests LGTM |
davidchambers
force-pushed
the
avaq/constraints
branch
from
5005a78 to
b5b7fe5
Compare
davidchambers
approved these changes
Apr 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #144