Update the equals function to fall back to structural equality #154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avaq
force-pushed
the
avaq/structural-equality
branch
from
82fb5b2 to
fd43ddc
Compare
|
I'm looking into what it means, conceptually, to make this same change to |
Avaq
commented
Apr 24, 2021
Avaq
commented
Apr 24, 2021
davidchambers
force-pushed
the
avaq/structural-equality
branch
2 times, most recently
from
1ac69a4 to
cc85990
Compare
|
I prefer this approach over the direction #147 is going. How do you feel about merging this @davidchambers ? |
davidchambers
force-pushed
the
avaq/structural-equality
branch
3 times, most recently
from
43bc871 to
13c24c8
Compare
I am happy with the new behaviour. I would like to spend some time reworking the function's description. |
Avaq
force-pushed
the
avaq/structural-equality
branch
from
52cbd75 to
299f5c2
Compare
Avaq
force-pushed
the
avaq/structural-equality
branch
from
299f5c2 to
2dea6ba
Compare
Avaq
commented
Jun 18, 2021
When comparing two values that are: 1. of the same type; and 2. do not provide a 'fantasy-land/equals'-method; but 3. also don't have a known type with a Z-provided implementation, then previously Z.equals would return false, but this false is just as reliable as a true would be. After this commit, instead of returning false, the Z.equals now returns the structural equality of the two inputs.
In particular, it should always be true for arbitrarily nested structures, where some layers have Setoid and some do not.
Avaq
force-pushed
the
avaq/structural-equality
branch
from
92f1ebc to
4892eda
Compare
davidchambers
approved these changes
Jun 19, 2021
This was referenced Aug 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR competes with and so closes #147
When comparing two values that are:
then previously Z.equals would return false, but this false is just as
reliable as a true would be.
After this PR, instead of returning false, the Z.equals now returns
the structural equality of the two inputs.