assert that ‘sort’ and ‘sortBy’ do not rely on Array#sort being stable #94
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on #92 I realized I could replace
idx: rs.length
withidx: 0
and all the tests would still pass. This is becauseArray#sort
is stable in my environment, as it is in most environments. The language specification does not guarantee this, though, so we should not assume it.This pull request introduces a function,
withUnstableArraySort
, which monkey patchesArray#sort
, evaluates a thunk, then restoresArray#sort
to its prior value. Any change toZ.sort
orZ.sortBy
which assumesArray#sort
to be stable will pass tests in the default environment but will fail some tests in the modified environment./cc @paldepind