use ES6 syntax #732
Merged
use ES6 syntax #732
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidchambers
commented
Dec 8, 2023
index.js
Outdated
| }), | ||
| {env} // see S.env doctest | ||
| ); | ||
| [Descending, Nil, Cons, Sum, S]; |
There was a problem hiding this comment.
These identifiers would otherwise only be referenced in doctests. Referencing them here avoids lint errors.
davidchambers
commented
Dec 8, 2023
Comment on lines
-3582
to
+3364
| function zipWith(f) { | ||
| return function(xs) { | ||
| return function(ys) { | ||
| var result = []; | ||
| var len = Math.min (xs.length, ys.length); | ||
| for (var idx = 0; idx < len; idx += 1) { | ||
| result.push (f (xs[idx]) (ys[idx])); | ||
| } | ||
| return result; | ||
| }; | ||
| }; | ||
| } | ||
| const zipWith = f => xs => ys => { | ||
| const result = new Array (Math.min (xs.length, ys.length)); | ||
| for (let idx = 0; idx < result.length; idx += 1) { | ||
| result[idx] = f (xs[idx]) (ys[idx]); | ||
| } | ||
| return result; | ||
| }; |
There was a problem hiding this comment.
I made a small optimization: calculating the length of the array up front.
davidchambers
commented
Dec 8, 2023
Comment on lines
-3887
to
3636
| function values(strMap) { | ||
| return Z.map (function(k) { return strMap[k]; }, Object.keys (strMap)); | ||
| } | ||
| _.values = { | ||
| consts: {}, | ||
| types: [$.StrMap (a), $.Array (a)], | ||
| impl: values | ||
| impl: Object.values, | ||
| }; |
There was a problem hiding this comment.
I simplified this implementation. ;)
davidchambers
commented
Dec 8, 2023
Comment on lines
-4409
to
+4126
| function match(pattern) { | ||
| return function(s) { | ||
| return Z.map (function(m) { return Z.map (toMaybe, m.slice (1)); }, | ||
| toMaybe (s.match (pattern))); | ||
| }; | ||
| function toMaybe(x) { return x == null ? Nothing : Just (x); } | ||
| } | ||
| const match = pattern => s => { | ||
| const match = s.match (pattern); | ||
| if (match == null) return Nothing; | ||
| const groups = new Array (match.length - 1); | ||
| for (let idx = 0; idx < groups.length; idx += 1) { | ||
| const group = match[idx + 1]; | ||
| groups[idx] = group == null ? Nothing : Just (group); | ||
| } | ||
| return Just (groups); | ||
| }; |
There was a problem hiding this comment.
I updated match to match matchAll.
Avaq
approved these changes
Dec 8, 2023
davidchambers
force-pushed
the
davidchambers/es6
branch
from
9c3a53b to
9baf9f7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#687