Majorana pool

[JamesB-1qbit]

Adds Majorana pool functions for use with ADAPTSolver

[ValentinS4t1qbit]

Good job with yield ! Some little things here and there and a bigger question.

[ValentinS4t1qbit]

1. I think you can just say "The arguments for the pool function" as the type is already clear in the docs.

2. It is not obvious why you're choosing to extend the functionality here. What was the rationale behind supporting dictionaries? Ideally I'd pick one or the other, and stay pythonic: one way to do things (and less code to maintain). If you have an opinion about what we should keep, that would be great.

[JamesB-1qbit]

I changed the type required to dictionary. I added the functionality because the get_majorana_uccgsd_pool function requires either a SecondQuantizedMolecule or n_sos. If left as a tuple, it would require the user to supply (None, number_of_spin_orbitals) to use the latter choice. The dictionary would be {"n_sos": number_of_spin_orbitals}.

[alexfleury-sb]

I have nothing important to say, it is great! Have you done something special with the notebook metadata or is it just as in your environment?

[JamesB-1qbit]

I have nothing important to say, it is great! Have you done something special with the notebook metadata or is it just as in your environment?

I only changed the pool_args to be a dictionary instead of a tuple. Nothing else would be different.

[ValentinS4t1qbit]

Looks good to me !