-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix MI-FNO link #169
Merged
Merged
Fix MI-FNO link #169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
README beautification and improvement of the text.
alexfleury-sb
requested review from
ValentinS4t1qbit and
JamesB-1qbit
as code owners
June 27, 2022 21:30
ValentinS4t1qbit
approved these changes
Jun 28, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job Alexandre, thank you for fixing this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Several key points:
get_results
function inqemist_client
. Themo_coeffs
are not available anymore in the MI results.FermionOperator
, but we do need all of them to redo the MI energy summation (epsilon are function of the correlation energies, and this info is only available in the fragment result dictionaries).sto-3g
basis for the HF example in the notebook. It makes the QITE quick to run. A drawback of this is that there is no FNO truncation (all correction are 0.0).