Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

switched where qiskit_noise_model is specified #354

Merged
merged 1 commit into from
Nov 24, 2023
Merged

switched where qiskit_noise_model is specified #354

merged 1 commit into from
Nov 24, 2023

Conversation

JamesB-1qbit
Copy link
Contributor

A test was failing because

backend = qiskit_aer.AerSimulator(method="statevector", noise_model=qiskit_noise_model)
translated_circuit = self.qiskit.transpile(translated_circuit, backend)
translated_circuit.save_statevector()
sim_results = backend.run(translated_circuit, shots=1).result()

works but our current version does not

backend = qiskit_aer.AerSimulator(method="statevector")
translated_circuit = self.qiskit.transpile(translated_circuit, backend)
translated_circuit.save_statevector()
sim_results = backend.run(translated_circuit, shots=1, noise_model=qiskit_noise_model).result()

@JamesB-1qbit JamesB-1qbit marked this pull request as ready for review November 24, 2023 19:06
ValentinS4t1qbit
ValentinS4t1qbit approved these changes Nov 24, 2023
View reviewed changes
Copy link
Collaborator

@ValentinS4t1qbit ValentinS4t1qbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this fix quickly !

@ValentinS4t1qbit ValentinS4t1qbit merged commit d26e11c into sandbox-quantum:develop Nov 24, 2023
9 checks passed
ValentinS4t1qbit added a commit that referenced this pull request Dec 20, 2023
@github-actions @ValentinS4t1qbit
@alexfleury-sb @JamesB-1qbit
New release v0.4.2 into main (#367)
44fe1d0 
* Helper class and functions for iFCI fragment import (#351)
* Set the instance in a Qiskit runtime job (#352)
* Added trim_qubits option to Circuit.split() (#353)
* Measurement Controlled operations (CMEASURE) (#334)
* Fix after qiskit update: qiskit_noise_model (#354)
* Bugfix: DMET fragment object initialization from IntegralSolver fixed (#355)
* added explicit mo_coeff for H4_cation (#356)
* VQE get_rdm performance improvements (#357)
* Implementation of Frozen Natural Orbitals (FNO) (#358)
* UHF reference symmetry labels. (#360)
* FNO: NotImplementedError for ROHF (#362)
* Iterative Quantum Phase Estimation (#359)
* README minor changes + feature overview link (#363)
* Add feature list (#364) (#365)

---------

Co-authored-by: Valentin Senicourt <41597680+ValentinS4t1qbit@users.noreply.github.com>
Co-authored-by: AlexandreF-1qbit <76115575+AlexandreF-1qbit@users.noreply.github.com>
Co-authored-by: James Brown <84878946+JamesB-1qbit@users.noreply.github.com>
Co-authored-by: James Brown <james.brown@1qbit.com>
Co-authored-by: ValentinS4t1qbit <valentin@goodchemistry.gmail>
ValentinS4t1qbit added a commit that referenced this pull request Dec 20, 2023
@ValentinS4t1qbit @alexfleury-sb @JamesB-1qbit
Catchup: develop to match main v0.4.2 (#368)
da95678 
* Main to catch up with develop (#344)
* Helper class and functions for iFCI fragment import (#351)
* Set the instance in a Qiskit runtime job (#352)
* Added trim_qubits option to Circuit.split() (#353)
* Measurement Controlled operations (CMEASURE) (#334)
* Fix after qiskit update: qiskit_noise_model (#354)
* Bugfix: DMET fragment object initialization from IntegralSolver fixed (#355)
* added explicit mo_coeff for H4_cation (#356)
* VQE get_rdm performance improvements (#357)
* Implementation of Frozen Natural Orbitals (FNO) (#358)
* UHF reference symmetry labels. (#360)
* FNO: NotImplementedError for ROHF (#362)
* Iterative Quantum Phase Estimation (#359)
* README minor changes + feature overview link (#363)
* Add feature list (#364) (#365)

---------

Co-authored-by: Valentin Senicourt <41597680+ValentinS4t1qbit@users.noreply.github.com>
Co-authored-by: AlexandreF-1qbit <76115575+AlexandreF-1qbit@users.noreply.github.com>
Co-authored-by: James Brown <84878946+JamesB-1qbit@users.noreply.github.com>
Co-authored-by: James Brown <james.brown@1qbit.com>
Co-authored-by: ValentinS4t1qbit <valentin@goodchemistry.gmail>
cburdine pushed a commit to cburdine/Tangelo that referenced this pull request May 31, 2024
@github-actions @ValentinS4t1qbit
@alexfleury-sb @JamesB-1qbit @cburdine
New release v0.4.2 into main (sandbox-quantum#367)
ab70d71 
* Helper class and functions for iFCI fragment import (sandbox-quantum#351)
* Set the instance in a Qiskit runtime job (sandbox-quantum#352)
* Added trim_qubits option to Circuit.split() (sandbox-quantum#353)
* Measurement Controlled operations (CMEASURE) (sandbox-quantum#334)
* Fix after qiskit update: qiskit_noise_model (sandbox-quantum#354)
* Bugfix: DMET fragment object initialization from IntegralSolver fixed (sandbox-quantum#355)
* added explicit mo_coeff for H4_cation (sandbox-quantum#356)
* VQE get_rdm performance improvements (sandbox-quantum#357)
* Implementation of Frozen Natural Orbitals (FNO) (sandbox-quantum#358)
* UHF reference symmetry labels. (sandbox-quantum#360)
* FNO: NotImplementedError for ROHF (sandbox-quantum#362)
* Iterative Quantum Phase Estimation (sandbox-quantum#359)
* README minor changes + feature overview link (sandbox-quantum#363)
* Add feature list (sandbox-quantum#364) (sandbox-quantum#365)

---------

Co-authored-by: Valentin Senicourt <41597680+ValentinS4t1qbit@users.noreply.github.com>
Co-authored-by: AlexandreF-1qbit <76115575+AlexandreF-1qbit@users.noreply.github.com>
Co-authored-by: James Brown <84878946+JamesB-1qbit@users.noreply.github.com>
Co-authored-by: James Brown <james.brown@1qbit.com>
Co-authored-by: ValentinS4t1qbit <valentin@goodchemistry.gmail>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ValentinS4t1qbit ValentinS4t1qbit ValentinS4t1qbit approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JamesB-1qbit @ValentinS4t1qbit