Fix innosetup script to remove shell integration keys

[mpheath]

Remove shell integration in innosetup fix with RegDeleteKeyIncludingSubkeys function, instead of RegDeleteValue function as sandbox is a registry key, not a registry value. RegDeleteValue would have been failing (with a return value of False) as it cannot remove keys and the subkeys as it is documented to remove a value.

These are the sandbox keys copied from RegEdit that require keys and subkeys removed at uninstall of Sandboxie Plus.

HKEY_CURRENT_USER\Software\Classes\*\shell\sandbox
HKEY_CURRENT_USER\Software\Classes\Folder\shell\sandbox

This fix has not been compiled and tested, though it should be an improvement. No other registry functions appear to have any similar issues with a quick review of the innosetup source.

[isaak654]

What do you think about adding these?

RegDeleteKeyIncludingSubkeys(HKEY_CLASSES_ROOT, '*\shell\sandbox');
RegDeleteKeyIncludingSubkeys(HKEY_CLASSES_ROOT, 'folder\shell\sandbox');

I'm not sure if they were part of an old Plus install

[mpheath]

HKEY_CLASSES_ROOT is a mirror of combined HKCU and HKLM. It should not be written to. Same could be said for removal. Writing to HKCR can overwrite whatever exists in HKCU or HKLM as you do not know at write time. It would not be recommended to handle, in my opinion. You may expect it to do HKCU, but if not there and HKLM entries exist, they may be removed even though they should remain. It may not do harm in this case.

[isaak654]

HKEY_CLASSES_ROOT is a mirror of combined HKCU and HKLM.

For some reason I forgot that detail, probably because other scripts try to fiddle with it.

Imho this pull request should be merged in the next few hours... especially if we consider that Google Safe Browsing could have marked the releases page as unsafe for the reason in highlight:

It would also be great if in another pull request we could clean the Sandboxie-Plus folders left by the uninstaller in AppData\Local and in ProgramFiles. I mentioned the exact behavior in the linked issue, when I suggested to introduce one prompt before or after the uninstall process that asks "Do you want to uninstall also your configuration files (Sandboxie.ini and Sandboxie-Plus.ini)?".