Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Plus upgrade install with full uninstall of service and driver #1141

Merged
merged 1 commit into from
Aug 28, 2021

Conversation

mpheath
Copy link
Collaborator

@mpheath mpheath commented Aug 26, 2021

Moved the kmdutil.exe delete SbieSvc and kmdutil delete SbieDrv Exec commands into ShutdownSbie(). Makes the upgrade install several seconds longer though recent and previous testing shows the elimination of the The service cannot accept control messages at this time messagebox.

Was not aware of a reboot needed due to the issue. Unless the shell has some handles or something locked open, then fingers crossed, this should prevent a needed reboot.

@mpheath mpheath marked this pull request as ready for review August 26, 2021 16:57
@mpheath
Copy link
Collaborator Author

mpheath commented Aug 27, 2021

I mentioned previous testing of this fix. This kmdutil fix posted was already intergrated into a alternative setup with status message improvements. This is something I consider pushing later. Part of the long upgrade and uninstall process lead to wanting better status messages to let the user know what is happening. It is not just added feature, but a tidied up script so may need some time to review. I could possibly update the existing script that is currently in use later with the feature, though a tidy up may be due. I posting this early to give some time for the consideration.

@DavidXanatos DavidXanatos merged commit b85b02b into sandboxie-plus:master Aug 28, 2021
@mpheath mpheath deleted the innosetup_upgrade_fix branch August 28, 2021 11:00
@isaak654
Copy link
Collaborator

I mentioned previous testing of this fix. This kmdutil fix posted was already intergrated into a alternative setup with status message improvements. This is something I consider pushing later. Part of the long upgrade and uninstall process lead to wanting better status messages to let the user know what is happening. It is not just added feature, but a tidied up script so may need some time to review. I could possibly update the existing script that is currently in use later with the feature, though a tidy up may be due. I posting this early to give some time for the consideration.

@mpheath
Your efforts to improve Plus installer are very appreciated here. Would you like to be invited as collaborator to this repository?

@mpheath
Copy link
Collaborator Author

mpheath commented Aug 29, 2021

@isaak654

Thankyou for the consideration. Some more direct interaction may help as being a collaborator at times. Send the invite and I will accept.

@DavidXanatos
Copy link
Member

@mpheath invite should be on its way :)

@mpheath
Copy link
Collaborator Author

mpheath commented Aug 29, 2021

@DavidXanatos invite received and accepted. Thankyou.

@offhub offhub added the Sbie Installer Sandboxie installer label Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Sbie Installer Sandboxie installer
Projects
None yet
4 participants