-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add torrent clients and media player templates along with classes for them #719
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-
In this case, I think it would be better to merge these changes to the previous pull request, in order to avoid potential conflicts: Add VLC Media Player and the MediaPlayer class to the templates #708
-
You forgot to add the class in this file:
ini.GetTemplateNames(L"WebBrowser", names);
Well crap. My plan was actually to wait with this one until the other one is merged, then I change it to remove the conflicts. |
If this was your intention, next time you could consider to open a pull request in draft mode. I think it's more useful in these cases, because it prevents a pull request to be merged accidentally: https://github.blog/2019-02-14-introducing-draft-pull-requests |
Sorry, I'm new when it comes to pull requests and GitHub usage in general. I'll use draft mode next time, but for now I think I don't think any major changes will be necessary. Planning on adding Transmission and BiglyBT later today. PicoTorrent already has a finished template, but has this issue making it virtually useless: #720 |
4394;txt;01 | ||
The following exclusions allow Media players running in this sandbox to access files outside the sandbox. | ||
. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You need to add this (it was in the old pull request):
4395;txt;01
Allow %2 direct access to the Photo folder for easier screen capture.
.
. | ||
|
||
4397;txt;01 | ||
The following exclusions allow Torrent clients running in this sandbox access to files outside the sandbox. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Replace it with:
The following exclusions allow Torrent clients running in this sandbox to access files outside the sandbox.
Hello! This adds qBittorrent as a default template, along with a class for it to fit into since "Download Manager" didn't really fit the bill.