Allow user to specify which broadcast IP to use for meshage #1458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In some cases, cluster compute nodes have multiple interfaces and networks they can communicate with each other over, and one may be desirable over another for meshage comms. By default, minimega uses `255.255.255.255` as the broadcast address, and when multiple interfaces are present, the one acting as the default route is the one used. This commit adds a new command line option, `-broadcast`, for users to specify which broadcast IP to use for the mesh. It defaults to `255.255.255.255`, so this commit should be backwards compatible.
|
@aherna anymore thoughts on this? It doesn't break normal, default behavior (i.e., it's backwards compatible) so I'm hoping you will be amenable to merging it in. |
|
@activeshadow Havent tested the with latest changes. Is this urgent or can it wait til new year? |
|
@aherna it can most definitely wait. |
|
Hi @aherna just wanted to ping you on this again. |
aherna
approved these changes
Jan 11, 2022
| func meshageStart(host, namespace string, degree, msaTimeout uint, broadcastIP string, port int) error { | ||
| bip := net.ParseIP(broadcastIP) | ||
| if bip == nil { | ||
| return fmt.Errorf("invalid broadcast IP %s for meshage", broadcastIP) |
There was a problem hiding this comment.
Would it be more appropriate to state that the broadcastIP is an invalid IP as its invalid because it failed to parse vs its not the right IP for meshage? @activeshadow
| f_base = flag.String("base", BASE_PATH, "base path for minimega data") | ||
| f_degree = flag.Uint("degree", 0, "meshage starting degree") | ||
| f_msaTimeout = flag.Uint("msa", 10, "meshage MSA timeout") | ||
| f_broadcastIP = flag.String("broadcast", "255.255.255.255", "meshage broadcast address to use") |
There was a problem hiding this comment.
Whats the use case here? A user can dial by specific IP or hostname to reach another Minimega instance and create a mesh. ie mesh dial
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some cases, cluster compute nodes have multiple interfaces and
networks they can communicate with each other over, and one may be
desirable over another for meshage comms. By default, minimega uses
255.255.255.255as the broadcast address, and when multiple interfacesare present, the one acting as the default route is the one used.
This commit adds a new command line option,
-broadcast, for users tospecify which broadcast IP to use for the mesh. It defaults to
255.255.255.255, so this commit should be backwards compatible.