fix json encoder bug for GPIBInstrument objects

[mplilly4395]

Update to the JSON encoder to deal with GPIBInstrument objects. There is no testing for this error yet.

[rsbrost]

This change looks constructive and has my approval as long as it is fixing the bug on your side. That said, I am not sure this is an all-inclusive list, but it looks like a good addition/fix at a minimum for now.

[rsbrost]

That said, the imports are failing test cases since for whatever reason the new pyvisa package pieces (such as Firewire, etc.) are not successfully imported by the github runner. I think we will need to add these explicitly to the pyscan setup.py for them to be recognized... might want to check with Andy on this.

[mplilly4395]

Take a look again. I am importing from pyvisa.resources now rather than pyvisa.resources.gpib (which only has GPIBInstrument). From: rsbrost ***@***.***> Date: Monday, August 26, 2024 at 10:40 AM To: sandialabs/pyscan ***@***.***> Cc: Lilly, Mike ***@***.***>, Author ***@***.***> Subject: [EXTERNAL] Re: [sandialabs/pyscan] fix json encoder bug for GPIBInstrument objects (PR #220) That said, the imports are failing test cases since for whatever reason the new pyvisa package pieces (such as Firewire, etc.) are not successfully imported by the github runner. I think we will need to add these explicitly to the pyscan setup.py for them to be recognized... might want to check with Andy on this. — Reply to this email directly, view it on GitHub<#220 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/A7HRKOBXFNVIPM57QOMIT2DZTNK6XAVCNFSM6AAAAABM4SNQ36VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMJQGYZDCOBTG4>. You are receiving this because you authored the thread.Message ID: ***@***.***>

[rsbrost]

Tested on lab experiment including srs830 as a device. I replicated the JSON encoder error, then pulled this branches changes and validated that they fix the issue. Merging now.