Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test nvc in CI #296

Conversation

insertinterestingnamehere
Copy link
Collaborator

No description provided.

@insertinterestingnamehere
Copy link
Collaborator Author

Looks like nvc doesn't doesn't (yet) support the gcc flags that automake is trying to use to generate dependency files. I think this is similar to what's discussed at: https://forums.developer.nvidia.com/t/issue-with-header-file-dependency-file-d-generation/221608. The fix isn't immediately obvious to me, but I'll leave this PR open for now.

@insertinterestingnamehere
Copy link
Collaborator Author

Alright, here's the plan: the dependency flag issue only applies to our assembly file so we're going to test nvc with our fast context swaps disabled until we can get the build system to play nice with its restricted flag options. That way this doesn't get blocked.

Some of the nvc warnings appear to be buggy, but I also fixed the ones I could as a part of this PR too.

@insertinterestingnamehere
Copy link
Collaborator Author

Github actions appears to be having an outage right now, so I'll come back and merge this in a bit once they get that working again so we can confirm that I didn't somehow break an existing supported config.

@insertinterestingnamehere insertinterestingnamehere merged commit 87e6f08 into sandialabs:release-1.22-pre Oct 8, 2024
294 of 361 checks passed
@insertinterestingnamehere insertinterestingnamehere added this to the 1.22 Release milestone Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant