Enable pre-commit.ci #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only enable standard pre-commit hooks to begin with.
jmgate
force-pushed
the
test-pre-commit-ci
branch
from
98da09a to
98c4b48
Compare
For some reason, Pyroma thinks this is a non-standard classifier.
We've transitioned fro YAPF to black for formatting.
Until we turn the bandit pre-commit hook on and deal with all the issues found.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type: Task
Description
Set up this repository with pre-commit.ci to enforce various things automatically (code formatting, documentation style, etc.).
Motivation
Just settings things up such that we keep everything clean from here on out.
Testing
Note the pre-commit.ci - pr check below. Clicking the
Detailslink shows you all the passing checks.Commits
chore: Add pre-commit configuration (98c4b48)
Only enable standard pre-commit hooks to begin with.
style: Ensure files end with a single blank line (41735da)
chore: Enable black pre-commit hook (f1c5c86)
style: Update files to match black style (cd58f9c)
chore: Enable pygrep pre-commit hooks (5aba441)
chore: Enable doc8 pre-commit hook (cf98d36)
chore: Enable flake8 pre-commit hook (76ba088)
style: Switch to idiomatic type check (f47e1bf)
chore: Enable isort pre-commit hook (09f0c46)
style: Sort imports (a66c3cf)
chore: Enable pydocstyle pre-commit hook (472bfc4)
style: Adhere to documentation style guide (3cb946d)
chore: Enable pyroma pre-commit hook (0415cac)
chore: Remove UNIX classifier (69927ce)
For some reason, Pyroma thinks this is a non-standard classifier.
chore: Remove YAPF disable flags (39fff4e)
We've transitioned fro YAPF to black for formatting.
docs: Remove bandit badge (fb9c508)
Until we turn the bandit pre-commit hook on and deal with all the issues found.