Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add LibreBoard to the list of applications #8

Merged
merged 1 commit into from
Jan 13, 2015
Merged

Add LibreBoard to the list of applications #8

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 18 additions & 1 deletion apps/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -292,7 +292,7 @@ <h3>MediaGoblin</h3>
<button onclick="install('a522699b2f89399b65400cf88540e70b?url=http://sandstorm.io/apps/telescope.spk')">Install »</button>
<h3>Telescope</h3>
<div class="app-details">
Originally by: <a href="https://github.com/SachaG">Sacha Greif</a> & <a href="https://github.com/tmeasday">Tom Coleman</a><br>
Originally by: <a href="https://github.com/SachaG">Sacha Greif</a> &amp; <a href="https://github.com/tmeasday">Tom Coleman</a><br>
Ported by: <a href="https://github.com/jparyani/">Jason Paryani</a><br>
License: MIT<br>
Code: <a href="https://github.com/jparyani/Telescope">On GitHub</a><br>
Expand All @@ -304,6 +304,23 @@ <h3>Telescope</h3>
<p><img src="telescope.png">
</div>

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @mquandalle and thanks for submitting this! I have some small comments that might improve this pull request. I'll let Kenton be the one to merge it or not, but wanted to give you this feedback with the goal of hopefully having you make a few small changes to improve the submission.

Even without the changes, I think this is shippable, but having noticed some things, I thought it'd be nice to share them.

<div class="app">
<button onclick="install('118d77fa72eba6a685cb493bffb18fae?url=https://github.com/libreboard/libreboard/releases/download/v0.7.1/libreboard.spk')">Install »</button>
<h3>LibreBoard</h3>
<div class="app-details">
Developed by: <a href="https://github.com/yasaricli">Yaşar İçli</a> &amp; <a href="https://github.com/mquandalle">Maxime Quandalle</a><br>
Version: 0.7.1<br>
License: MIT<br>
Code: <a href="https://github.com/libreboard/libreboard">On GitHub</a><br>
Updated: Jan 11 2015
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Personally I would also like to put a version number here; Version: 0.7.1, but this is not consistent with other applications. Should I do it anyway?

</div>
<p>A “kanban” board similar to Trello that let you organize things in cards, and cards in
lists. It supports most features you can expect (labels, comments, markdown formatting...)
and is built on <a href="https://meteor.com">Meteor</a>. Sandstorm is officialy supported
by the development team so no port was needed.
<p><img src="libreboard.png">
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for not catching this last time, but -- it's often good to specify width and height for images. I imagine this it not a show-stopper and I don't know if we're doing some cool trickery with responsive images that would obviate the need for that anyway.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, none of the other images have width/height, so we might as well just plan to fix this whole page up later. :)

</div>

<div class="app">
<button onclick="install('0a9206137db58d7e292b2d3f2fe5ceb5?url=http://sandstorm.io/apps/jparyani/ipython-15.spk')">Install »</button>
<h3>IPython Notebook</h3>
Expand Down
Binary file added apps/libreboard.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.