Skip to content

Commit

Permalink
Improve semver check for modules polyfill
Browse files Browse the repository at this point in the history
The polyfill uses the Ember global, which is deprecated in `3.27.0`.
This additionally disables the polyfill for the `3.27.0-beta.x` ranges.

Fixes embroider-build#781.
  • Loading branch information
sandydoo committed Apr 27, 2021
1 parent 8b2c20d commit 506c01f
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion packages/compat/src/compat-app.ts
Original file line number Diff line number Diff line change
Expand Up @@ -361,7 +361,7 @@ class CompatAppAdapter implements AppAdapter<TreeNames> {
}

let emberSource = this.activeAddonChildren().find(a => a.name === 'ember-source')!;
let emberNeedsModulesPolyfill = semver.satisfies(emberSource.version, '<3.27.0', { includePrerelease: true });
let emberNeedsModulesPolyfill = semver.satisfies(emberSource.version, '<3.27.0-beta.0', { includePrerelease: true });

return {
activeAddons,
Expand Down

0 comments on commit 506c01f

Please sign in to comment.