Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert rna feature translate #19

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion gff3toembl/convert.py
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ class Convert(object):
feature_attributes_to_ignore = {'ID': 1, 'protein_id': 1}
feature_attributes_translations = {'eC_number': 'EC_number'}
feature_attributes_to_split_on_multiple_lines = {'inference': 1, 'EC_number': 1}
feature_attributes_regex_to_change_feature_name = {'^16S ribosomal RNA': 'rRNA'}
feature_attributes_regex_to_change_feature_name = {}

feature_attributes_inference_to_dbxref = {'similar to AA sequence:UniProtKB': 'UniProtKB/Swiss-Prot', 'protein motif:Pfam': 'PFAM', 'protein motif:CLUSTERS': "CDD", 'protein motif:Cdd': "CDD", 'protein motif:TIGRFAMs': "TIGRFAM"}

Expand Down
17 changes: 0 additions & 17 deletions gff3toembl/tests/EMBLWriter_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -97,22 +97,5 @@ def test_chromosome_list_conversion(self):
assert filecmp.cmp(os.path.join(data_dir, 'expected_chromosome_list.txt'), 'chromosome_list.txt', shallow=False)
os.remove('chromosome_list.embl')
os.remove('chromosome_list.txt')

def test_renaming_16s_features(self):
'''test renaming the feature type to rRNA if the product is 16S'''
emblwriter = EMBLWriter(os.path.join(data_dir,'input_16s.gff'),
'Organism',
1234,
'ABC',
'My description',
'John',
'Some title',
'Some journal',
'circular',
'PROK',
'16s.embl', None, 11, None )
emblwriter.parse_and_run()
assert filecmp.cmp(os.path.join(data_dir, 'expected_16s.embl'), '16s.embl', shallow=False)
os.remove('16s.embl')


181 changes: 0 additions & 181 deletions gff3toembl/tests/data/expected_16s.embl

This file was deleted.

20 changes: 0 additions & 20 deletions gff3toembl/tests/data/input_16s.gff

This file was deleted.

2 changes: 1 addition & 1 deletion setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ def read(fname):

setup(
name='gff3toembl',
version='0.3.8',
version='0.3.9',
description='Convert a GFF3 file to EMBL format for submission',
long_description=read('README.md'),
packages = find_packages(),
Expand Down