Un-escape %2C to comma etc for GFF3 to EMBL #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This closes sanger-pathogens#50 with what is essentially a workaround. The existing code assumes that genometools does not do the unescaping, and therefore can handle multi-value attributes using this pattern: attribute_values = attribute_value.split(',') Therefore rather than applying the unescaping as early as possible in the GFF3 parsing, I have applied is as late as possible in the EMBL output. See also genometools/genometools#198
|
Thanks a million for the fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes #50 with what is essentially a workaround, using the
urllib.unquotefunction.The existing code assumes that genometools does not do the unescaping, and therefore can handle multi-value attributes using this pattern:
Therefore rather than applying the unescaping as early as possible in the GFF3 parsing, I have applied is as late as possible in the EMBL output.
See also genometools/genometools#198