fix: Avoid duplicate downloads in nested subworkflows #9
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modules.json test failures related to duplicate entries happens because meta.yml declares modules that are not imported in the actual subworkflow code, since they're only used in the nested subworkflow.
This way the module gets downloaded twice, hence the longer "installed_by" in modules.json.
This PR makes it so the new installation procedure checks if a module/subwf declared in meta.yml is actually imported in main.nf, and only proceeds with installation in that case.
PR checklist
CHANGELOG.md
is updateddocs
is updated