Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Avoid duplicate downloads in nested subworkflows #9

Merged
merged 1 commit into from
Aug 5, 2024

Conversation

jvfe
Copy link
Collaborator

@jvfe jvfe commented Aug 5, 2024

Modules.json test failures related to duplicate entries happens because meta.yml declares modules that are not imported in the actual subworkflow code, since they're only used in the nested subworkflow.

image

This way the module gets downloaded twice, hence the longer "installed_by" in modules.json.

This PR makes it so the new installation procedure checks if a module/subwf declared in meta.yml is actually imported in main.nf, and only proceeds with installation in that case.

PR checklist

  • This comment contains a description of changes (with reason)
  • CHANGELOG.md is updated
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

@jvfe jvfe requested a review from muffato August 5, 2024 13:18
@jvfe jvfe merged commit 792f68b into fix/1927 Aug 5, 2024
23 of 33 checks passed
@jvfe jvfe deleted the fix/duplicated-downloads branch August 13, 2024 20:10
@muffato muffato added the bug Something isn't working label Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Development

Successfully merging this pull request may close these issues.

2 participants