Skip to content
This repository has been archived by the owner on Oct 26, 2020. It is now read-only.

Updates for Scala 2.13 #1

Merged
merged 26 commits into from
Oct 25, 2019
Merged

Updates for Scala 2.13 #1

merged 26 commits into from
Oct 25, 2019

Conversation

travisbrown
Copy link

@travisbrown travisbrown commented Oct 25, 2019

I'm moving this pull request from here as discussed here.

All of our Sangria dependencies here (including the test ones) are now published with Scala 2.13 support. There are some breaking changes, so I've bumped the major version to 2.0.0. Please see the original PR for details.

I think we should publish this as a 2.0.0-M1 today, and plan to publish a 2.0.0 in a week or two if no major issues come up.

@travisbrown travisbrown requested a review from yanns October 25, 2019 13:55
@travisbrown
Copy link
Author

@yanns What do you think about merging this and publishing it as a milestone release today? That gives people an easier way to try it out, but also leaves us some space to sneak other changes into 2.0.0 if we decide we want them.

@travisbrown
Copy link
Author

I've seen a few of these flaky failures in CI today in other projects:

[error] java.lang.ArrayIndexOutOfBoundsException: 52857
[error] scala.tools.asm.ClassReader.readLabel(ClassReader.java:2262)
[error] scala.tools.asm.ClassReader.createLabel(ClassReader.java:2269)

It doesn't look familiar to me, and I'm not sure what's going on. Previously restarting has fixed it, so I'm trying that here.

Copy link

@yanns yanns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

too many changes... 😭

I agree to go with a RC release first.

@travisbrown
Copy link
Author

@yanns Great, thanks! I'll publish it shortly. I think it'd be better to go with a milestone than a release candidate (to give other contributors a chance to move over PRs without the pressure of a release candidate), so it'll be 2.0.0-M1, if that sounds good to you.

@travisbrown travisbrown merged commit 59f1bfd into master Oct 25, 2019
@yanns
Copy link

yanns commented Oct 25, 2019

@travisbrown 2.0.0-M1 sounds perfect.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants